fix: remove reserved properties from function signatures (#4205)

fern-api · Aug 5, 2024 · 21c5779 · 21c5779
1 parent abb1f37
commit 21c5779
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 14 deletions.
diff --git a/generators/ruby/codegen/src/ast/abstractions/SerializableObject.ts b/generators/ruby/codegen/src/ast/abstractions/SerializableObject.ts
@@ -34,10 +34,13 @@ export const FieldsetProperty = new Property({
     type: GenericClassReference,
     isOptional: true
 });
+
 export declare namespace SerializableObject {
     export type Init = Omit<Class_.Init, "functions" | "includeInitializer" | "expressions">;
 }
 export class SerializableObject extends Class_ {
+    public static INTERNAL_FIELDS = [AdditionalPropertiesProperty.name, FieldsetProperty.name];
+
     constructor(init: SerializableObject.Init) {
         super({
             ...init,

diff --git a/generators/ruby/sdk/CHANGELOG.md b/generators/ruby/sdk/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+## [0.8.2] - 2024-08-05
+
+- Fix: The generated endpoint functions no long include object utilities such as `_field_set` or `additional_properties`.
+
 ## [0.8.1] - 2024-07-22
 
 - Fix: Nested `hash` types are recursively resolved in `from_json` such that they come back as true hashes, as opposed to structs

diff --git a/generators/ruby/sdk/VERSION b/generators/ruby/sdk/VERSION
@@ -1 +1 @@
-0.8.1
+0.8.2
diff --git a/generators/ruby/sdk/src/utils/EndpointGenerator.ts b/generators/ruby/sdk/src/utils/EndpointGenerator.ts
@@ -22,6 +22,7 @@ import {
     LiteralClassReference,
     Parameter,
     Property,
+    SerializableObject,
     StringClassReference,
     Variable,
     VariableType,
@@ -273,6 +274,11 @@ export class EndpointGenerator {
             }
         });
 
+        // Remove reserved properties from the function signature
+        this.bodyAsProperties = this.bodyAsProperties.filter(
+            (prop) => !SerializableObject.INTERNAL_FIELDS.includes(prop.name)
+        );
+
         this.streamProcessingBlock = this.isStreamingResponse()
             ? new Parameter({
                   name: "on_data",

diff --git a/seed/ruby-sdk/extends/lib/fern_extends.rb b/seed/ruby-sdk/extends/lib/fern_extends.rb