Skip to content

Commit

Permalink
(fix, csharp): uuids are now generated as strings (#4122)
Browse files Browse the repository at this point in the history
  • Loading branch information
dsinghvi authored Jul 25, 2024
1 parent 4c0a159 commit 4525ec3
Show file tree
Hide file tree
Showing 205 changed files with 108 additions and 499 deletions.
2 changes: 1 addition & 1 deletion generators/csharp/codegen/src/ast/InstantiatedPrimitive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export class PrimitiveInstantiation extends AstNode {
break;
}
case "uuid":
writer.write(`new Guid("${this.internalType.value}")`);
writer.write(this.internalType.value.toString());
break;
case "null":
writer.write("null");
Expand Down
2 changes: 1 addition & 1 deletion generators/csharp/codegen/src/context/CsharpTypeMapper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export class CsharpTypeMapper {
long: () => csharp.Type.long(),
date: () => csharp.Type.date(),
dateTime: () => csharp.Type.dateTime(),
uuid: () => csharp.Type.uuid(),
uuid: () => csharp.Type.string(),
// https://learn.microsoft.com/en-us/dotnet/api/system.convert.tobase64string?view=net-8.0
base64: () => csharp.Type.string(),
_other: () => csharp.Type.object(),
Expand Down
5 changes: 5 additions & 0 deletions generators/csharp/sdk/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.3.0 - 2024-07-25]

- Break: Convert all usages `Guid` to be `string` since the `Guid` class changes the underlying
casing.

## [0.2.2 - 2024-07-25]

- Improvement: Add header suppliers to `RawClient` constructor parameters.
Expand Down
9 changes: 1 addition & 8 deletions seed/csharp-sdk/alias/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Empty file.
Empty file.
9 changes: 1 addition & 8 deletions seed/csharp-sdk/api-wide-base-path/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Empty file.
Empty file.
9 changes: 1 addition & 8 deletions seed/csharp-sdk/audiences/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Empty file.
Empty file.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 1 addition & 8 deletions seed/csharp-sdk/auth-environment-variables/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Empty file.
Empty file.
9 changes: 1 addition & 8 deletions seed/csharp-sdk/basic-auth-environment-variables/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Empty file.
Empty file.
9 changes: 1 addition & 8 deletions seed/csharp-sdk/basic-auth/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Empty file.
Empty file.
9 changes: 1 addition & 8 deletions seed/csharp-sdk/bearer-token-environment-variable/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Empty file.
Empty file.
9 changes: 1 addition & 8 deletions seed/csharp-sdk/bytes/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Empty file.
Empty file.
9 changes: 1 addition & 8 deletions seed/csharp-sdk/circular-references-advanced/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Empty file.
Empty file.
9 changes: 1 addition & 8 deletions seed/csharp-sdk/circular-references/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Empty file.
Empty file.
9 changes: 1 addition & 8 deletions seed/csharp-sdk/code-samples/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Empty file.
Empty file.
9 changes: 1 addition & 8 deletions seed/csharp-sdk/custom-auth/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Empty file.
Empty file.
9 changes: 1 addition & 8 deletions seed/csharp-sdk/enum/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Empty file.
Empty file.
Loading

0 comments on commit 4525ec3

Please sign in to comment.