fix(java): Don't generate pagination with nonempty path (#5385)

* fix(java): Don't generate pagination with nonempty path * test run * changelog entry * Add streaming-parameter to expected failures * Format --------- Co-authored-by: Alberto <alberto@buildwithfern.com>
fern-api · Dec 11, 2024 · d1fba2d · d1fba2d
1 parent eb5316e
commit d1fba2d
Show file tree

Hide file tree

Showing 14 changed files with 71 additions and 34 deletions.
diff --git a/...va/sdk/src/main/java/com/fern/java/client/generators/endpoint/AbstractEndpointWriter.java b/...va/sdk/src/main/java/com/fern/java/client/generators/endpoint/AbstractEndpointWriter.java
@@ -713,6 +713,10 @@ public JsonResponseBodyWithProperty _visitUnknown(Object unknownType) {
                 httpEndpoint.getPagination().get().visit(new Visitor<Void>() {
                     @Override
                     public Void visitCursor(CursorPagination cursor) {
+                        if (cursor.getPage().getPropertyPath().isPresent()
+                                && !cursor.getPage().getPropertyPath().get().isEmpty()) {
+                            return null;
+                        }
                         SnippetAndResultType nextSnippet = getNestedPropertySnippet(
                                 cursor.getNext().getPropertyPath(),
                                 cursor.getNext().getProperty(),
@@ -797,6 +801,10 @@ public String _visitUnknown(Object o) {
 
                     @Override
                     public Void visitOffset(OffsetPagination offset) {
+                        if (offset.getPage().getPropertyPath().isPresent()
+                                && !offset.getPage().getPropertyPath().get().isEmpty()) {
+                            return null;
+                        }
                         com.fern.ir.model.types.TypeReference pageType = offset.getPage()
                                 .getProperty()
                                 .visit(new RequestPropertyValue.Visitor<com.fern.ir.model.types.TypeReference>() {

diff --git a/generators/java/sdk/versions.yml b/generators/java/sdk/versions.yml
@@ -1,3 +1,10 @@
+- changelogEntry:
+    - summary: |
+        Don't generate pagination with nonempty path. Fixes pagination seed tests breaking.
+      type: fix
+  createdAt: '2024-12-10'
+  irVersion: 53
+  version: 2.6.0
 - changelogEntry:
     - summary: |
         Bump IR version to latest (v53)

diff --git a/seed/java-sdk/inline-types/.gradle/8.11.1/checksums/checksums.lock b/seed/java-sdk/inline-types/.gradle/8.11.1/checksums/checksums.lock
diff --git a/seed/java-sdk/inline-types/.gradle/8.11.1/checksums/md5-checksums.bin b/seed/java-sdk/inline-types/.gradle/8.11.1/checksums/md5-checksums.bin
diff --git a/seed/java-sdk/inline-types/.gradle/8.11.1/checksums/sha1-checksums.bin b/seed/java-sdk/inline-types/.gradle/8.11.1/checksums/sha1-checksums.bin
diff --git a/seed/java-sdk/inline-types/.gradle/8.11.1/executionHistory/executionHistory.bin b/seed/java-sdk/inline-types/.gradle/8.11.1/executionHistory/executionHistory.bin
diff --git a/seed/java-sdk/inline-types/.gradle/8.11.1/executionHistory/executionHistory.lock b/seed/java-sdk/inline-types/.gradle/8.11.1/executionHistory/executionHistory.lock
diff --git a/seed/java-sdk/inline-types/.gradle/8.11.1/fileHashes/fileHashes.bin b/seed/java-sdk/inline-types/.gradle/8.11.1/fileHashes/fileHashes.bin
diff --git a/seed/java-sdk/inline-types/.gradle/8.11.1/fileHashes/fileHashes.lock b/seed/java-sdk/inline-types/.gradle/8.11.1/fileHashes/fileHashes.lock
diff --git a/seed/java-sdk/inline-types/.gradle/buildOutputCleanup/buildOutputCleanup.lock b/seed/java-sdk/inline-types/.gradle/buildOutputCleanup/buildOutputCleanup.lock
diff --git a/seed/java-sdk/inline-types/.gradle/buildOutputCleanup/cache.properties b/seed/java-sdk/inline-types/.gradle/buildOutputCleanup/cache.properties
diff --git a/seed/java-sdk/object/src/main/java/com/seed/object/types/Type.java b/seed/java-sdk/object/src/main/java/com/seed/object/types/Type.java
diff --git a/seed/java-sdk/pagination/src/main/java/com/seed/pagination/resources/users/UsersClient.java b/seed/java-sdk/pagination/src/main/java/com/seed/pagination/resources/users/UsersClient.java
diff --git a/seed/java-sdk/seed.yml b/seed/java-sdk/seed.yml
@@ -1,4 +1,4 @@
-irVersion: v46
+irVersion: v53
 displayName: Java SDK
 changelogLocation: ../../generators/java/sdk/versions.yml
 image: fernapi/fern-java-sdk
@@ -100,3 +100,4 @@ allowedFailures:
   - query-parameters
   - trace
   - unions
+  - streaming-parameter