Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java, fix: match java local config to publish config #4127

Merged
merged 2 commits into from
Jul 26, 2024
Merged

java, fix: match java local config to publish config #4127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef9c7ed
done
dcb6 Jul 26, 2024
7bc2e5b
changelog
dcb6 Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions generators/java/sdk/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.0.5] - 2024-07-26

* Fix: Fixed a bug where local generation custom config doesn't pick up some values, including exception naming.

## [1.0.4] - 2024-07-24

* Fix: Fixed a bug where OkHttp responses could be closed prematurely.
Expand Down
3 changes: 3 additions & 0 deletions generators/java/sdk/src/main/java/com/fern/java/client/Cli.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,9 @@ public void runInDownloadFilesModeHook(
JavaSdkCustomConfig.builder()
.wrappedAliases(customConfig.wrappedAliases())
.clientClassName(customConfig.clientClassName())
.baseApiExceptionClassName(customConfig.baseApiExceptionClassName())
.baseExceptionClassName(customConfig.baseExceptionClassName())
.customDependencies(customConfig.customDependencies())
.build(),
clientPoetClassNameFactory,
new FeatureResolver(ir, generatorConfig, generatorExecClient).getResolvedAuthSchemes());
Expand Down
10 changes: 10 additions & 0 deletions generators/java/sdk/src/main/java/com/fern/java/client/JavaSdkDownloadFilesCustomConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
import com.fern.java.DownloadFilesCustomConfig;
import com.fern.java.immutables.StagedBuilderImmutablesStyle;
import java.util.List;
import java.util.Optional;
import org.immutables.value.Value;

Expand All @@ -31,6 +32,15 @@ public interface JavaSdkDownloadFilesCustomConfig extends DownloadFilesCustomCon
@JsonProperty("client-class-name")
Optional<String> clientClassName();

@JsonProperty("base-api-exception-class-name")
Optional<String> baseApiExceptionClassName();

@JsonProperty("base-exception-class-name")
Optional<String> baseExceptionClassName();

@JsonProperty("custom-dependencies")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tossed this in here since it seemed like we might as well

Optional<List<String>> customDependencies();

static ImmutableJavaSdkDownloadFilesCustomConfig.Builder builder() {
return ImmutableJavaSdkDownloadFilesCustomConfig.builder();
}
Expand Down
Loading