Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feature): Add IRv53; float type #4146

Merged
merged 3 commits into from
Jul 30, 2024
Merged

(feature): Add IRv53; float type #4146

merged 3 commits into from
Jul 30, 2024

Conversation

amckinney
Copy link
Contributor

This introduces IRv53 which is similar in spirit to IRv52 (re: #4102), but adds the float primitive type.

To prevent future breaking changes, this also adds a separate key, value pair for every PrimitiveType (in both the v1 and v2 variants), which is shown below:

types:
  PrimitiveTypeV2:
    union:
      integer: IntegerType
      long: LongType
      uint: UintType
      uint64: Uint64Type
      float: FloatType
      double: DoubleType
      boolean: BooleanType
      string: StringType
      date: DateType
      dateTime: DateTimeType
      uuid: UuidType
      base64: Base64Type
      bigInteger: BigIntegerType
  ...

  FloatType:
    properties: {}

  ...

Any of the types that do not yet support default values or validation rules are defined as an empty object so that we can add to them in a backwards compatible manner. We also assign a name (rather than an in-lined {}), which makes it even easier for generators later on.

@amckinney amckinney requested a review from dsinghvi as a code owner July 29, 2024 23:26
@amckinney amckinney marked this pull request as draft July 29, 2024 23:27
@amckinney amckinney marked this pull request as ready for review July 30, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants