-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feature, csharp): Add RequestOptions #4166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsinghvi
reviewed
Jul 31, 2024
dsinghvi
reviewed
Jul 31, 2024
dsinghvi
reviewed
Jul 31, 2024
dcb6
reviewed
Jul 31, 2024
dcb6
reviewed
Jul 31, 2024
dcb6
reviewed
Jul 31, 2024
seed/csharp-sdk/basic-auth/src/SeedBasicAuth/BasicAuth/BasicAuthClient.cs
Outdated
Show resolved
Hide resolved
dcb6
reviewed
Jul 31, 2024
...multi-url-environment-no-default/src/SeedMultiUrlEnvironmentNoDefault/Core/RequestOptions.cs
Outdated
Show resolved
Hide resolved
dcb6
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the
RequestOptions
type, which exposes the same set of properties as theClientOptions
, but does not include any default values. That way, any option explicitly set by the user at the request call-site will take precedence over the options set on the client constructor.For example,
This also updates the
TimeoutInSeconds
option (currently unused) to be aTimeSpan
. This is more idiomatic and gives the user more control over exactly how they want to construct the time span before it's passed into the HTTP client.