Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: python readme references request options correctly #4189

Merged
merged 2 commits into from
Aug 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion generators/python/sdk/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [3.3.0-rc1] - 2024-07-31
## [3.3.1] - 2024-08-02

- Fix: Generated READMEs now reference RequestOptions as TypedDicts correctly.

## [3.3.0-rc1] - 2024-08-01

- Fix: TypedDict snippets now include literals where available.

Expand Down
2 changes: 1 addition & 1 deletion generators/python/sdk/VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.3.0-rc1
3.3.1
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ def _build_timeout_snippets(self) -> List[str]:

client_instantiation = AST.ClassInstantiation(
class_=self._root_client.sync_client.class_reference,
args=[AST.Expression("..."), AST.Expression("{ timeout=20.0 }")],
args=[AST.Expression("..."), AST.Expression(f'{ "timeout": 20.0 }')],
)

def _client_writer(writer: AST.NodeWriter) -> None:
Expand All @@ -134,7 +134,7 @@ def _client_writer(writer: AST.NodeWriter) -> None:

# Override timeout for a specific method
client.{endpoint.endpoint_package_path}{endpoint.method_name}({"...," if has_parameters else ""}{{
timeout_in_seconds=1
"timeout_in_seconds": 1
}})
"""
)
Expand Down Expand Up @@ -188,7 +188,7 @@ def _build_retries_snippets(self) -> List[str]:
has_parameters = self._endpoint_metadata.has_parameters(endpoint_id)
retry_snippets.append(
f"""client.{endpoint.endpoint_package_path}{endpoint.method_name}({"...," if has_parameters else ""}{{
max_retries=1
"max_retries": 1
}})
"""
)
Expand All @@ -201,7 +201,7 @@ def _build_custom_client_snippets(self) -> str:
args=[AST.Expression("...")],
kwargs=[
(
"http_client",
"httpx_client",
AST.Expression(
AST.ClassInstantiation(
class_=HttpX.CLIENT,
Expand Down
131 changes: 0 additions & 131 deletions seed/python-sdk/alias/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

137 changes: 0 additions & 137 deletions seed/python-sdk/api-wide-base-path/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading