Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat, python): upgrade python generator to pydantic v2 #4197

Merged
merged 15 commits into from
Aug 5, 2024

Conversation

dsinghvi
Copy link
Member

@dsinghvi dsinghvi commented Aug 4, 2024

What did this involve?

  • Regenerating the IR SDK with native support for Pydantic V2
  • Regenerating the FDR snippets SDK with native support for Pydantic V2
  • Regenerating the Generator CLI SDK with native support for Pydantic V2
  • Upgrading mypy to the latest (caught some typing issues)

What is the benefit?
This can save more than 15+ seconds in the python generator. Pydantic vaildation is ~5-50x faster than Pydantic V1 which makes a big difference when the IR sizes are extremely large.

@dsinghvi dsinghvi marked this pull request as ready for review August 4, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant