Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix, python + ts: additional template bugs #4198

Merged
merged 6 commits into from
Aug 5, 2024

Conversation

armandobelardo
Copy link
Contributor

@armandobelardo armandobelardo commented Aug 4, 2024

Before this PR:

  • The union templates had the incorrect location
  • The certain fields in python were missing a location
  • We were not making literals as union members
  • TS was not correctly making object all the time

Of note:
The undiscriminated union template takes a location directly on it, the idea here is the resolver grabs that payload and passes it into the members to score and resolve those templates.
That means that the members themselves need to be relative templates (relative to the payload grabbed from the union template itself), and the union itself needs to pass in the payload at it's given location (e.g. what JSON object represents all the union members)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants