(feat): cli caches api dependencies #4201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,14 +1,17 @@ | |||
| import { dependenciesYml } from "@fern-api/configuration"; | |||
| import { VersionedDependency } from "@fern-api/configuration/src/dependencies-yml"; | |||
There was a problem hiding this comment.
Mega nit - looks like this might not be exported from the top level index.ts
| metadata = response.body; | ||
| await writeFile(pathToMetadata, JSON.stringify(metadata)); | ||
| } else { | ||
| metadata = JSON.parse((await readFile(pathToMetadata)).toString()); |
There was a problem hiding this comment.
Is there any validation, similar to the above that needs to be done after reading in the dir? I'd imagine no since it's version specific, so should be used immediately
There was a problem hiding this comment.
Yup no validation needs to be done
armandobelardo
approved these changes
Aug 6, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than reoloading dependencies again and again, they are now cached in the
~/.fernfolder as well as theLazyFernWorkspace.