(feat, python): move to ruff for formatting #4219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generators/python/src/fern_python/generator_cli/readme_snippet_builder.py
Outdated
Show resolved
Hide resolved
generators/python/src/fern_python/snippet/snippet_template_factory.py
Outdated
Show resolved
Hide resolved
dsinghvi
force-pushed
the
dsinghvi/ruff-support
branch
from
d0e75b1 to
f10a091
Compare
armandobelardo
approved these changes
Aug 9, 2024
dsinghvi
added a commit
that referenced
this pull request
Aug 9, 2024
dsinghvi
added a commit
that referenced
this pull request
Aug 9, 2024
dsinghvi
added a commit
that referenced
this pull request
Aug 10, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
SourceFileImplsthat are created in a project are no longer formatted via black. They are formatted via ruff at the end in one big go.SourceFileFactory.create_snippet()is called the user has to pass inshould_format. Now we ensure that respect theskip_formattingflag.This does not modify
WriterImplto format via ruff since there is work required to make that functionality accessible via python.