fix: if audience is filtering and no audiences exist on environments, add all environments #4220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ke sure that errant audiences don't pass
RohinBhargava
commented
Aug 6, 2024
packages/cli/generation/ir-generator/src/__test__/irs/environmentAudiencesAllHack.json
Show resolved
Hide resolved
RohinBhargava
commented
Aug 6, 2024
packages/cli/generation/ir-generator/src/__test__/irs/environmentAudiencesSelectHack.json
Show resolved
Hide resolved
|
Old tests have no diff. Random audiences are not actually allowed in this layer |
dsinghvi
reviewed
Aug 6, 2024
packages/cli/generation/ir-generator/src/generateIntermediateRepresentation.ts
Outdated
Show resolved
Hide resolved
dsinghvi
reviewed
Aug 6, 2024
packages/cli/generation/ir-generator/src/filtered-ir/IrGraph.ts
Outdated
Show resolved
Hide resolved
…but-no-environment-audience-specified
…ronment-audience-specified' of https://github.com/fern-api/fern into rohin/special-case-audience-supplied-on-cli-but-no-environment-audience-specified
dsinghvi
approved these changes
Aug 6, 2024
dsinghvi
deleted the
rohin/special-case-audience-supplied-on-cli-but-no-environment-audience-specified
branch
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added hack tests and overrideChecks -- have to do here in order to make sure that errant audiences don't pass