c#, fix: fix type conflicts #4244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcb6
commented
Aug 9, 2024
| _client = client; | ||
| } | ||
|
|
||
| public async System.Threading.Tasks.Task HelloAsync(RequestOptions? options = null) |
There was a problem hiding this comment.
here is example of fix that will be applied directly merge
amckinney
approved these changes
Aug 12, 2024
dsinghvi
approved these changes
Aug 12, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In one of our generated SDKs, we saw a
Taskgenerated type conflict with theSytem.Threading.TasksTaskthat is used as an async method return type, leading to compile breaks.Solution
To check for potential conflicts, we now collect every generated type
ClassReferenceand compare to aClassReferencethat we are about to write. If there are any otherClassReferences with the samenameas the one we're about to write, we fully qualify the type inline (rather than adding the import) to disambiguate.