(feat, typescript): support hasNextPage property for offset pagination
#4288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsinghvi
commented
Aug 12, 2024
| @@ -532,7 +532,7 @@ export class Users { | |||
| let _offset = request?.page != null ? request?.page : 1; | |||
| return new core.Pageable<SeedPagination.ListUsersPaginationResponse, SeedPagination.User>({ | |||
| response: await list(request), | |||
| hasNextPage: (response) => (response?.data ?? []).length > 0, | |||
| hasNextPage: (response) => response?.hasNextPage ?? (response?.data ?? []).length > 0, | |||
There was a problem hiding this comment.
Sweet, deferring to the length check is great 👍
amckinney
reviewed
Aug 12, 2024
generators/typescript/sdk/generator/src/contexts/SdkContextImpl.ts
Outdated
Show resolved
Hide resolved
amckinney
reviewed
Aug 12, 2024
generators/typescript/sdk/generator/src/contexts/SdkContextImpl.ts
Outdated
Show resolved
Hide resolved
amckinney
approved these changes
Aug 12, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the TypeScript IR by a minor version and adds support for looking at a
hasNextPageproperty for pagination.