fix(cli): openapi importer supports a setting for making additional properties optional #4667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amckinney
approved these changes
Sep 17, 2024
| @@ -9,11 +9,14 @@ export interface ParseOpenAPIOptions { | |||
| useTitlesAsName: boolean; | |||
| /* The audiences that the OpenAPI must be filtered down into */ | |||
| audiences: string[] | undefined; | |||
| /* Whether or not to make additional proeprties optional */ | |||
There was a problem hiding this comment.
Suggested change
| /* Whether or not to make additional proeprties optional */ | |
| /* Whether or not to make additional properties optional */ |
There was a problem hiding this comment.
Could also make this slightly more clear and say "... property values optional".
…onal additional properties
dsinghvi
force-pushed
the
dsinghvi/add-optional-additional-properties-flag
branch
from
8cb6dd1 to
2468515
Compare
dsinghvi
deleted the
dsinghvi/add-optional-additional-properties-flag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…onal additional properties
This PR introduces a new feature to allow additional properties in OpenAPI to be optional.
Changes
optionalAdditionalPropertiesfield is added to the APIDefinitionSettings interface.optionalAdditionalPropertiesfield is added to the SpecImportSettings interface.optionalAdditionalPropertiesfield is added to the ParseOpenAPIOptions interface.optionalAdditionalPropertiesfield is added to the OSSWorkspace.Settings interface.optionalAdditionalPropertiesfield is added to the Workspace interface.optionalAdditionalPropertiesfield is added to the OpenAPISettingsSchema and AsyncAPISettingsSchema objects.optionalAdditionalPropertiesfield is added to the OpenAPISpecSchema and AsyncAPISchema objects.optionalAdditionalPropertiesfield is added to the parseAPIConfigurationToApiLocations function.optionalAdditionalPropertiesfield is added to the convertAdditionalProperties function.optionalAdditionalPropertiesfield is added to the loadSingleNamespaceAPIWorkspace function.