fix(cli): namespacing no longer breaks when objects conflict across namespaces #4673

armandobelardo · 2024-09-17T20:06:57Z

This PR introduces a new feature, adding support for chat messages in the API. It also includes some refactoring and bug fixes.

Changes

Added a new V2ChatMessages type to represent chat messages.
Added a new messages field to the Pet and Station types.
Refactored the writeDefinitionForOpenAPIWorkspace function to use a new writeModels function.
Updated the Endpoint and Webhook types to include a new WithNamespace field.
Updated the EndpointWithExample type to include a new WithNamespace field.
Updated the Namespace type to include a new WithNamespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace type to include a new namespace field.
Updated the NamespaceId type to include a new namespace field.
Updated the WithNamespace

…ross namespaces

gitguardian · 2024-09-17T20:07:04Z

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
6585115	Triggered	Generic High Entropy Secret	`44dca16`	packages/cli/openapi-ir-to-fern/src/test/snapshots/axle.test.ts.snap	View secret
6585115	Triggered	Generic High Entropy Secret	`44dca16`	packages/cli/openapi-ir-to-fern/src/test/snapshots/axle.test.ts.snap	View secret
6585115	Triggered	Generic High Entropy Secret	`44dca16`	packages/cli/openapi-ir-to-fern/src/test/snapshots/axle.test.ts.snap	View secret
6585115	Triggered	Generic High Entropy Secret	`44dca16`	packages/cli/openapi-ir-to-fern/src/test/snapshots/axle.test.ts.snap	View secret
13738502	Triggered	Generic High Entropy Secret	`46cb3fb`	generators/java/sdk/versions.yml	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

armandobelardo added 10 commits September 9, 2024 15:36

[WIP] fix(cli): namespacing no longer breaks when objects conflict ac…

c97263b

…ross namespaces

bump v

7550aa3

this route feels wrong

a6f9192

not fully working

cafb060

working, need to polish

30dc3eb

update snaps

f954501

bring back tests

46cb3fb

bring back tests

44dca16

remove sentinel

f34338d

merge main

c4fde91

armandobelardo added 2 commits September 17, 2024 17:40

merge main

8d72cde

ci and changelog

c76bdb1

armandobelardo changed the title ~~[DNM] Un-botched merge from namespacing~~ fix(cli): namespacing no longer breaks when objects conflict across namespaces Sep 17, 2024

armandobelardo marked this pull request as ready for review September 17, 2024 21:44

armandobelardo requested a review from dsinghvi as a code owner September 17, 2024 21:44

update snap

395e625

dsinghvi approved these changes Sep 17, 2024

View reviewed changes

armandobelardo merged commit a97860e into main Sep 17, 2024
47 checks passed

armandobelardo deleted the ab/fix-namespacing-again branch September 17, 2024 22:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(cli): namespacing no longer breaks when objects conflict across namespaces #4673

fix(cli): namespacing no longer breaks when objects conflict across namespaces #4673

armandobelardo commented Sep 17, 2024 •

edited by cohere-assist bot

Loading

gitguardian bot commented Sep 17, 2024 •

edited

Loading

fix(cli): namespacing no longer breaks when objects conflict across namespaces #4673

fix(cli): namespacing no longer breaks when objects conflict across namespaces #4673

Conversation

armandobelardo commented Sep 17, 2024 • edited by cohere-assist bot Loading

Changes

gitguardian bot commented Sep 17, 2024 • edited Loading

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

armandobelardo commented Sep 17, 2024 •

edited by cohere-assist bot

Loading

gitguardian bot commented Sep 17, 2024 •

edited

Loading