Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): remove errant default values on primitives (date primitives) #5381

Merged
merged 8 commits into from
Dec 11, 2024
Merged

fix(cli): remove errant default values on primitives (date primitives) #5381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
14c5537
remove errant default values on primitives (date primitives)
fern-support Dec 10, 2024
a4be08b
bump cli version
fern-support Dec 10, 2024
4d0988c
update snapshots
fern-support Dec 10, 2024
7a6c6d2
chore: update changelog
fern-support Dec 10, 2024
eb1c034
make non rc
fern-support Dec 11, 2024
f314a5d
Merge branch 'rohin/remove-errant-defaults' of https://github.com/fer…
fern-support Dec 11, 2024
bb163fb
merge from main and release non-rc
fern-support Dec 11, 2024
38e0d32
chore: update changelog
fern-support Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions fern/pages/changelogs/cli/2024-12-11.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
## 0.45.4
**`(fix):`** Defaults are no longer set on datetimes when converting to docs shapes.


9 changes: 8 additions & 1 deletion packages/cli/cli/versions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
- changelogEntry:
- summary: |
Defaults are no longer set on datetimes when converting to docs shapes.
type: fix
irVersion: 53
version: 0.45.4

- changelogEntry:
- summary: |
Bumped Java IR to latest (v53)
Expand All @@ -23,7 +30,7 @@
- summary: |
Example generation now respects read-only schemas when generating request examples.
type: fix
irVersion: 53
irVersion: 53
version: 0.45.2

- changelogEntry:
Expand Down
6 changes: 2 additions & 4 deletions ...ster/src/ir-to-fdr-converter/__test__/__snapshots__/basic-auth-environment-variables.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@
"value": {
"type": "primitive",
"value": {
"type": "boolean",
"default": false
"type": "boolean"
}
}
}
Expand Down Expand Up @@ -131,8 +130,7 @@
"value": {
"type": "primitive",
"value": {
"type": "boolean",
"default": false
"type": "boolean"
}
}
}
Expand Down
6 changes: 2 additions & 4 deletions packages/cli/register/src/ir-to-fdr-converter/__test__/__snapshots__/basic-auth.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@
"value": {
"type": "primitive",
"value": {
"type": "boolean",
"default": false
"type": "boolean"
}
}
}
Expand Down Expand Up @@ -131,8 +130,7 @@
"value": {
"type": "primitive",
"value": {
"type": "boolean",
"default": false
"type": "boolean"
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions ...ages/cli/register/src/ir-to-fdr-converter/__test__/__snapshots__/circular-references.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,7 @@
"type": {
"type": "primitive",
"value": {
"type": "boolean",
"default": false
"type": "boolean"
}
}
}
Expand Down
12 changes: 4 additions & 8 deletions ...register/src/ir-to-fdr-converter/__test__/__snapshots__/csharp-grpc-proto-exhaustive.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,8 +703,7 @@
"type": {
"type": "primitive",
"value": {
"type": "boolean",
"default": false
"type": "boolean"
}
}
}
Expand Down Expand Up @@ -956,8 +955,7 @@
"itemType": {
"type": "primitive",
"value": {
"type": "boolean",
"default": false
"type": "boolean"
}
}
}
Expand Down Expand Up @@ -1448,8 +1446,7 @@
"itemType": {
"type": "primitive",
"value": {
"type": "boolean",
"default": false
"type": "boolean"
}
}
}
Expand All @@ -1461,8 +1458,7 @@
"itemType": {
"type": "primitive",
"value": {
"type": "boolean",
"default": false
"type": "boolean"
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions packages/cli/register/src/ir-to-fdr-converter/__test__/__snapshots__/csharp-grpc-proto.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,7 @@
"type": {
"type": "primitive",
"value": {
"type": "boolean",
"default": false
"type": "boolean"
}
}
}
Expand Down
6 changes: 2 additions & 4 deletions packages/cli/register/src/ir-to-fdr-converter/__test__/__snapshots__/custom-auth.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@
"value": {
"type": "primitive",
"value": {
"type": "boolean",
"default": false
"type": "boolean"
}
}
}
Expand Down Expand Up @@ -131,8 +130,7 @@
"value": {
"type": "primitive",
"value": {
"type": "boolean",
"default": false
"type": "boolean"
}
}
}
Expand Down
24 changes: 8 additions & 16 deletions packages/cli/register/src/ir-to-fdr-converter/__test__/__snapshots__/examples.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,7 @@
"valueType": {
"type": "primitive",
"value": {
"type": "base64",
"default": "0"
"type": "base64"
}
}
}
Expand Down Expand Up @@ -357,8 +356,7 @@
"valueType": {
"type": "primitive",
"value": {
"type": "long",
"default": 0
"type": "long"
}
}
}
Expand Down Expand Up @@ -533,8 +531,7 @@
"valueType": {
"type": "primitive",
"value": {
"type": "date",
"default": "1970-01-01T00:00:00.000Z"
"type": "date"
}
}
},
Expand All @@ -543,8 +540,7 @@
"valueType": {
"type": "primitive",
"value": {
"type": "datetime",
"default": "1970-01-01T00:00:00.000Z"
"type": "datetime"
}
}
}
Expand Down Expand Up @@ -998,8 +994,7 @@
"valueType": {
"type": "primitive",
"value": {
"type": "boolean",
"default": false
"type": "boolean"
}
}
}
Expand All @@ -1016,8 +1011,7 @@
"valueType": {
"type": "primitive",
"value": {
"type": "boolean",
"default": false
"type": "boolean"
}
}
}
Expand Down Expand Up @@ -1588,8 +1582,7 @@
"value": {
"type": "primitive",
"value": {
"type": "boolean",
"default": false
"type": "boolean"
}
}
}
Expand Down Expand Up @@ -1890,8 +1883,7 @@
"itemType": {
"type": "primitive",
"value": {
"type": "boolean",
"default": false
"type": "boolean"
}
}
}
Expand Down
Loading
Loading