feat(cli): support bytes in the fern definition #5388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsinghvi
force-pushed
the
dsinghvi/support-bytes-in-the-fern-definition
branch
from
738a94b to
ef8c601
Compare
| 🌿 Preview your docs: https://fern-preview-38514ce8-81cf-4c82-af25-6b7e33427721.docs.buildwithfern.com/learn |
chdeskur
approved these changes
Dec 11, 2024
|
docs look good to me |
amckinney
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR supports responses that are bytes. The motivation here is to not 1) force users to specify
filewhen they actually return bytes and 2) allow the generators to generate more idiomatic code like returning anArrayBuffer.Changes Made
HttpResponseBodyas part of IR V54anybc union visiting is annoying and we know the types will align in a specific case)Testing