Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to remove bucket #10

Merged
merged 3 commits into from
Oct 21, 2017

Conversation

redroot
Copy link
Contributor

@redroot redroot commented Oct 20, 2017

References this issue: #9

Adds the command serverless client remove which empties the bucket and removes it. Some notes:

  1. I refactored to make use of the functions that finds and empties the bucket from the deploy command. Im not overly familiar with the Class-style syntax in JS these days, so let me know what you think
  2. I also added an arbitary 3 second delay to the remove process, as its clearly a very destructive process! Not sure if thats overkill though, thoughts?

screen shot 2017-10-20 at 10 51 50

@fernando-mc fernando-mc changed the title Remove functionality Add functionality to remove bucket Oct 21, 2017
@fernando-mc
Copy link
Owner

@redroot This works cleanly. I'm going to look at the other PRs that are currently pending but this will get into a new version for sure.

@fernando-mc fernando-mc self-requested a review October 21, 2017 04:05
@fernando-mc fernando-mc merged commit de3073c into fernando-mc:master Oct 21, 2017
@fernando-mc
Copy link
Owner

@redroot Thanks for the PR! All merged. I will be updating the package over the weekend. If you don't see it before Monday please bug me about it. I still have to get some CI/CD setup on this so it isn't automatic yet.

@fernando-mc
Copy link
Owner

@redroot This is now live in v1.2.2 . Thanks for the PR!

@redroot
Copy link
Contributor Author

redroot commented Oct 22, 2017

@fernando-mc No worries, happy to help!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants