Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update awsRegionUrls.json with new regions #101

Merged
merged 3 commits into from
Jun 21, 2020

Conversation

triptec
Copy link
Contributor

@triptec triptec commented Apr 22, 2020

@triptec
Copy link
Contributor Author

triptec commented Apr 22, 2020

should close #72

Copy link
Owner

@fernando-mc fernando-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @triptec thanks for adding!

Did you have a chance to test the new additions? I made a few comments that I saw deviate from the documentation on website endpoints here - https://docs.aws.amazon.com/general/latest/gr/s3.html

Access endpoints vs. website endpoints I think are different in behavior.

For example - I see you added the new af-south-1 region but I don't see support for website endpoints for it? https://docs.aws.amazon.com/general/latest/gr/s3.html

Similarly, the . vs the - in ap-east-1 may be incorrect?

lib/resources/awsRegionUrls.json Outdated Show resolved Hide resolved
lib/resources/awsRegionUrls.json Outdated Show resolved Hide resolved
lib/resources/awsRegionUrls.json Outdated Show resolved Hide resolved
@triptec
Copy link
Contributor Author

triptec commented Apr 23, 2020

Oh, I was obviously making assumptions I should not have. Updated the PR to just add what I know.

@fernando-mc fernando-mc merged commit d794680 into fernando-mc:master Jun 21, 2020
@fernando-mc
Copy link
Owner

Just cut a new release. This should be included in v2.6.0 @triptec. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants