.subarray method should return Buffer instance

[mikeal]

Ran across this one today.

Buffer.subarray() in Node.js will return a Buffer instance, but in the browser it returns a Uint8Array.

[feross]

I wasn't able to reproduce the issue in Chrome, Brave, Firefox, or Safari on desktop. Which browser did you use?

I tested by browserifying and running:

const Buffer = require('./').Buffer
const a = Buffer.from('test')
console.log(a.subarray(2, 3).constructor.name)

which prints out Buffer.

[mikeal]

I’m using polendina for testing, which is a headless chrome that uses webpack (not browserify). I’m also importing the module explicitly rather that relying on globals.

[feross]

There's some weirdness going on with the Symbol.species code:

buffer/index.js

Lines 111 to 120 in b0a6de5

	// Fix subarray() in ES2016. See: https://github.com/feross/buffer/pull/97
	if (typeof Symbol !== 'undefined' && Symbol.species != null &&
	Buffer[Symbol.species] === Buffer) {
	Object.defineProperty(Buffer, Symbol.species, {
	value: null,
	configurable: true,
	enumerable: false,
	writable: false
	})
	}

Need to investigate further. Related: #97

[feross]

@mikeal Can you try the fix in this PR? #263