fix: feature detection for Google Chrome #16
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds explicit check if
chrome.sockets.udp
exist before registering related listeners.Why?
chrome-dgram
did not check ifchrome.sockets.udp
APIs actually exist, which caused problems in browser extensions, making it difficult to maintain a single codebase and do feature-detection at runtime (namely, Google Chrome withoutchrome.sockets.udp
vs Brave with).Refs. feross/chrome-net#36, ipfs/ipfs-companion#664 ipfs/ipfs-companion#716