Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support URL_PREFIX #114

Closed
fescobar opened this issue Aug 10, 2020 · 5 comments
Closed

Support URL_PREFIX #114

fescobar opened this issue Aug 10, 2020 · 5 comments
Labels
new feature New Feature released Released

Comments

@fescobar
Copy link
Owner

Useful for reverse proxy configuration like NGINX

    environment:
      URL_PREFIX: "/reporting"
@fescobar fescobar added new feature New Feature work in progress Work in progress labels Aug 10, 2020
This was referenced Aug 10, 2020
fescobar pushed a commit that referenced this issue Aug 10, 2020
@fescobar fescobar added ready to be released Ready to be released and removed work in progress Work in progress labels Aug 10, 2020
@fescobar
Copy link
Owner Author

@apulverizer I've almost finished a big refactoring. Please, check your feature in the beta version. I hope soon release this together with Security layer feature.

Before pulling, remove any previous beta if you have one.

  allure:
    image: "frankescobar/allure-docker-service:beta"

Please, let me know when you finish and don't use beta versions for prod environments, because it will be removed once we finished testing.

Thank you so much again.

@fescobar fescobar added the testing Testing label Aug 10, 2020
@apulverizer
Copy link
Contributor

This looks good to me using the "frankescobar/allure-docker-service:beta" image. Thanks for cleaning it up and adding this @fescobar

@fescobar
Copy link
Owner Author

@apulverizer Thank you for your feedback. Give me a few days to finish the security layer and release your code.
Thanks.

@fescobar fescobar removed the testing Testing label Aug 11, 2020
@fescobar fescobar added released Released and removed ready to be released Ready to be released labels Sep 1, 2020
@fescobar
Copy link
Owner Author

fescobar commented Sep 1, 2020

@apulverizer I've re-released the version 2.13.5 with your feature. Remove your current version and pull again the latest.
https://github.com/fescobar/allure-docker-service/releases/tag/v2.13.5

Also, I've created a new UI: https://github.com/fescobar/allure-docker-service-ui

Thank you so much for your help.

@apulverizer
Copy link
Contributor

Looks good, thanks. You can close this.

@fescobar fescobar closed this as completed Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New Feature released Released
Projects
None yet
Development

No branches or pull requests

2 participants