-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Average surface and volume derived quantities in Cylindrical and Spherical #820
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #820 +/- ##
==========================================
- Coverage 99.27% 99.27% -0.01%
==========================================
Files 60 60
Lines 2753 2744 -9
==========================================
- Hits 2733 2724 -9
Misses 20 20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# dV_z = r dr dtheta , assuming axisymmetry dV_z = theta r dr | ||
# dV_r = r dz dtheta , assuming axisymmetry dV_r = theta r dz | ||
# in both cases the expression with self.dx is the same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not true for spherical, please adapt
|
||
my_export = AverageVolumeSpherical("solute", 1) | ||
V = f.FunctionSpace(mesh_fenics, "P", 1) | ||
c_fun = lambda r: c_left + (c_right - c_left) / (r1 - r0) * r |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why this tests passes, please consider the above comment
Co-authored-by: Rémi Delaporte-Mathurin <40028739+RemDelaporteMathurin@users.noreply.github.com>
Proposed changes
With these new exports, users can take results from 1/2D simulations and extrapolate them for cylindrical and spherical cases.
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...