-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CLI GUI #2284
Remove CLI GUI #2284
Conversation
the reason is that it was missing also before this commit. It was discovered because the CLI GUI dependencies were removed, which included the needed ones for the HTTP server connection.
tox.ini
Outdated
openapi-core==0.13.2 | ||
openapi-spec-validator==0.2.8 | ||
aiohttp==3.6.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are they needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because pylint
gives errors on http_server/connection.py. And they are not installed from testenv
because we are overriding deps
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to configure .pylintrc
to ignore them and revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the assets in docs as well
527c12b
to
e18d280
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2284 +/- ##
===========================================
- Coverage 99.94% 99.45% -0.50%
===========================================
Files 299 420 +121
Lines 23580 30651 +7071
===========================================
+ Hits 23568 30485 +6917
- Misses 12 166 +154
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Remove the CLI GUI command. Update docs and tests accordingly.
Fixes
Fix #2090
Types of changes
What types of changes does your code introduce to agents-aea?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.develop
branch (left side). Also you should start your branch off ourdevelop
.aea cli
tool worksFurther comments
n/a