Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CLI GUI #2284

Merged
merged 6 commits into from
Feb 23, 2021
Merged

Remove CLI GUI #2284

merged 6 commits into from
Feb 23, 2021

Conversation

marcofavorito
Copy link
Contributor

Proposed changes

Remove the CLI GUI command. Update docs and tests accordingly.

Fixes

Fix #2090

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have checked that the documentation about the aea cli tool works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

n/a

the reason is that it was missing also before
this commit. It was discovered because
the CLI GUI dependencies were removed,
which included the needed ones for the HTTP server connection.
tox.ini Outdated
Comment on lines 173 to 175
openapi-core==0.13.2
openapi-spec-validator==0.2.8
aiohttp==3.6.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are they needed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because pylint gives errors on http_server/connection.py. And they are not installed from testenv because we are overriding deps here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to configure .pylintrc to ignore them and revert

Copy link
Contributor

@DavidMinarsch DavidMinarsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the assets in docs as well

@codecov-io
Copy link

Codecov Report

Merging #2284 (e18d280) into develop (29b8dee) will decrease coverage by 0.49%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2284      +/-   ##
===========================================
- Coverage    99.94%   99.45%   -0.50%     
===========================================
  Files          299      420     +121     
  Lines        23580    30651    +7071     
===========================================
+ Hits         23568    30485    +6917     
- Misses          12      166     +154     
Flag Coverage Δ
unittests 99.45% <100.00%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aea/cli/core.py 100.00% <ø> (ø)
...gins/aea-crypto-cosmos/aea_crypto_cosmos/cosmos.py 60.88% <100.00%> (ø)
...s/aea-crypto-fetchai/aea_crypto_fetchai/_cosmos.py 95.31% <100.00%> (ø)
.../fetchai/skills/tac_control_contract/parameters.py 100.00% <0.00%> (ø)
...s/aea-crypto-fetchai/aea_crypto_fetchai/fetchai.py 100.00% <0.00%> (ø)
...ea-crypto-ethereum/aea_crypto_ethereum/ethereum.py 97.79% <0.00%> (ø)
packages/fetchai/skills/tac_negotiation/helpers.py 100.00% <0.00%> (ø)
aea/exceptions.py 100.00% <0.00%> (ø)
...ackages/fetchai/skills/generic_seller/dialogues.py 100.00% <0.00%> (ø)
...ckages/fetchai/skills/confirmation_aw1/__init__.py 100.00% <0.00%> (ø)
... and 117 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29b8dee...e18d280. Read the comment docs.

Copy link
Contributor

@DavidMinarsch DavidMinarsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavidMinarsch DavidMinarsch merged commit d84735a into develop Feb 23, 2021
@DavidMinarsch DavidMinarsch deleted the fix/2090 branch February 25, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants