Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable PyLint #251

Merged
merged 14 commits into from
Sep 12, 2022
Merged

Re-enable PyLint #251

merged 14 commits into from
Sep 12, 2022

Conversation

VijaySharma815
Copy link
Contributor

@VijaySharma815 VijaySharma815 commented Aug 22, 2022 •
edited
Loading

@VijaySharma815 VijaySharma815 requested a review from 5A11 August 22, 2022 07:32
@5A11 5A11 mentioned this pull request Aug 24, 2022
Closed
3 tasks
@VijaySharma815 VijaySharma815 marked this pull request as ready for review August 26, 2022 03:17
@jrriehl jrriehl requested a review from solarw August 31, 2022 10:29
@VijaySharma815 VijaySharma815 mentioned this pull request Sep 4, 2022
Merged
2 tasks
@VijaySharma815 VijaySharma815 linked an issue Sep 4, 2022 that may be closed by this pull request
Re-enable PyLint #244
Closed
3 tasks
5A11
5A11 reviewed Sep 8, 2022
View reviewed changes
cosmpy/crypto/address.py Outdated Show resolved Hide resolved
5A11
5A11 reviewed Sep 8, 2022
View reviewed changes
tests/integration/test_tx.py Outdated Show resolved Hide resolved
5A11
5A11 reviewed Sep 8, 2022
View reviewed changes
tests/integration/test_tx.py Outdated Show resolved Hide resolved
5A11
5A11 reviewed Sep 8, 2022
View reviewed changes
tox.ini Show resolved Hide resolved
5A11
5A11 reviewed Sep 9, 2022
View reviewed changes
.pylintrc Outdated Show resolved Hide resolved
@5A11
Copy link
Member

5A11 commented Sep 9, 2022

Please update the list of ignored errors according to what we discussed before and address the complaints raised by the ones we are not ignoring.

5A11
5A11 approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@5A11 5A11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@5A11 5A11 merged commit 24c570b into develop Sep 12, 2022
@5A11 5A11 deleted the reenable_pylint branch September 12, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5A11 5A11 5A11 approved these changes

@solarw solarw Awaiting requested review from solarw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-enable PyLint
2 participants
@VijaySharma815 @5A11