fix(options/use_browser_cookies): disable encoding cookie value

ff14-advanced-market-search · Sep 3, 2024 · 9554bb0 · 9554bb0
1 parent 1c9e4de
commit 9554bb0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/sessions/index.ts b/app/sessions/index.ts
@@ -55,7 +55,7 @@ async function getUserSessionData(request: Request) {
 
   const getCookieValue = (name: string) => {
     const match = cookieHeader.match(new RegExp(`(^| )${name}=([^;]+)`))
-    return match ? match[2] : undefined
+    return match ? decodeURIComponent(match[2]) : undefined
   }
 
   const getFF14Data = () => {
@@ -77,7 +77,7 @@ async function getUserSessionData(request: Request) {
     if (regionCookie && realmIdCookie && realmNameCookie) {
       return validateServerAndRegion(
         regionCookie as WoWServerRegion,
-        realmIdCookie,
+        Number(realmIdCookie),
         realmNameCookie
       )
     }

diff --git a/app/utils/cookies.ts b/app/utils/cookies.ts
@@ -6,5 +6,5 @@ export function setCookie(
   options: { maxAge?: number; path?: string } = {}
 ) {
   const { maxAge = defaultMaxAge, path = '/' } = options
-  return `${name}=${encodeURIComponent(value)}; Max-Age=${maxAge}; Path=${path}; HttpOnly; Secure; SameSite=Lax`
+  return `${name}=${value}; Max-Age=${maxAge}; Path=${path}; HttpOnly; Secure; SameSite=Lax`
 }