Do not check for OptO in scripts

See haskell#8963 for reason and clarification requests.
ffaf1 · Oct 3, 2023 · 5d228f6 · 5d228f6
1 parent f213532
commit 5d228f6
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/Cabal/src/Distribution/PackageDescription/Check/Target.hs b/Cabal/src/Distribution/PackageDescription/Check/Target.hs
@@ -796,9 +796,13 @@ checkGHCOptions title t opts = do
       checkFlags
         ["-prof"]
         (PackageBuildWarning $ OptProf title)
-      checkFlags
-        ["-o"]
-        (PackageBuildWarning $ OptO title)
+      -- Does not apply to scripts.
+      -- Why do we need this? See #8963.
+      pid <- asksCM (pnPackageId . ccNames)
+      unless (pid == fakePackageId) $
+        checkFlags
+          ["-o"]
+          (PackageBuildWarning $ OptO title)
       checkFlags
         ["-hide-package"]
         (PackageBuildWarning $ OptHide title)