Skip to content

Commit

Permalink
Do not check for OptO in scripts
Browse files Browse the repository at this point in the history
See haskell#8963 for reason and clarification requests.
  • Loading branch information
ffaf1 committed Sep 27, 2023
1 parent de5f869 commit 710b442
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions Cabal/src/Distribution/PackageDescription/Check/Target.hs
Original file line number Diff line number Diff line change
Expand Up @@ -796,9 +796,13 @@ checkGHCOptions title t opts = do
checkFlags
["-prof"]
(PackageBuildWarning $ OptProf title)
checkFlags
["-o"]
(PackageBuildWarning $ OptO title)
-- Does not apply to scripts.
-- Why do we need this? See #8963.
pid <- asksCM (pnPackageId . ccNames)
unless (pid == fakePackageId) $
checkFlags
["-o"]
(PackageBuildWarning $ OptO title)
checkFlags
["-hide-package"]
(PackageBuildWarning $ OptHide title)
Expand Down

0 comments on commit 710b442

Please sign in to comment.