-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve missing lang
test case
#396
Comments
I have been researching a bit thanks to the #397 issue and I haven't found any standard regarding whitespaces on the
If we take a look at the BCP 47 language tags we can see that, in fact, no language tag has any whitespace, but that is an extracted pattern. We can also say that no language tag has a number on it, or a dollar sign ($). Should we extract some patterns from the list and apply it to the rule? |
@Dionakra We may try, if that does not represent a too complex pattern to check. CSS is quite bad at regexing :D As mentionned in #397, as far as I understand there's no room for whitespaces if we consider spec says So after new readings:
As often, an issue will mostly turn into more docs and references 👍 |
@matuzo wrote about the
lang
attribute and how to check it, quoting a11y.css in the way. However his suggestion (on CodePen) is way more efficient than our own by using::lang()
pseudo-class alongside attribute selector: should be a warning only to me since it depends on the page/website;lang
attribute using[lang*=" "]
(which is realy clever and should be used on other selectors too, let me open another issue!).Defintely need to implement this :)
The text was updated successfully, but these errors were encountered: