Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

Model relations introspection is permission-aware #6

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pliniocsfernandes
Copy link

Avoid listing relations which the user has no view or change access.
This avoids a bug that occurs when the current user has no access to a related
model but tries to select it on the report. Also, it makes the UI less cluttered.

Avoid listing relations which the user has no view or change access.
This avoids a bug that occurs when the current user has no access to a related
model but tries to select it on the report. Also, it makes the UI less cluttered.
@codecov
Copy link

codecov bot commented Jul 10, 2017

Codecov Report

Merging #6 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop       #6   +/-   ##
========================================
  Coverage    86.36%   86.36%           
========================================
  Files            7        6    -1     
  Lines          286      286           
  Branches        46       47    +1     
========================================
  Hits           247      247           
  Misses          26       26           
  Partials        13       13
Impacted Files Coverage Δ
export_action/views.py 96.82% <ø> (ø) ⬆️
export_action/introspection.py 84.7% <100%> (+0.18%) ⬆️
export_action/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1d4d3d...713c262. Read the comment docs.

@fgmacedo
Copy link
Owner

Hi @pliniocsfernandes, thanks for your time and effort on doing this enhancement.
Can you consider to write a few tests to cover this feature?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants