Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window function imports from scipy.signal #100

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

michael-kuhlmann
Copy link
Contributor

In version 1.13.0, scipy removed the ability to import window functions from the signal namespace (see scipy/scipy#19676). Window functions such as hamming have now to be imported from scipy.signal.windows.

scipy 1.13.0 release notes: https://scipy.github.io/devdocs/release/1.13.0-notes.html#pull-requests-for-1-13-0

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.55%. Comparing base (73eae1f) to head (5a70672).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #100   +/-   ##
=======================================
  Coverage   65.55%   65.55%           
=======================================
  Files          81       81           
  Lines        5496     5496           
=======================================
  Hits         3603     3603           
  Misses       1893     1893           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-kuhlmann michael-kuhlmann merged commit e3c5109 into fgnt:master Apr 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants