Explicit Letter class for avoiding name conflict
#108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seem this failed lint didn't occur from my change. But if you want to fix in this PR, I can. |
|
Hey @shishi, just a heads up that this is something that will come along with the upcoming 2.0 I got in the works, see the PR linked above for more. If you have the time, it'd be great if you could give that branch a try as well, tks in advance! |
|
Just got a pre-release ready to go. Please give that a try when you get a chance and I'll also just ping more folks for testing before a final release. This PR should auto close after code is on master. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I installed letter_opener_web in my rails app, I found conflicting
Letterclass with my ownLetterclass.I'd like to explicit
Letterclass's name space inletter_opener_web.If there is other solutions without changing
letter_opener_web, I'd like to choose that.