Fixed call to #rendered_messages #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit: ryanb/letter_opener@e5fbf0f#diff-2e20cc2a223324b62e266a1e07ce55e7 `LetterOpener::Message.rendered_messages` changed from... ```ruby def self.rendered_messages(location, mail) ``` ...to... ```ruby def self.rendered_messages(mail, options = {}) ``` `location` is now an option, and not an argument to the method.
|
Hey @keithpitt, I believe this was resolved in #73. |
|
Ah doh! Yeah, that would do it :) I didn't catch it in the pull request title that it had already been fixed. Thanks! |
|
v1.3.2 was released today with the fix applied. Thanks for the PR anyways though! |
|
No worries, and thanks for taking the time to look after the gem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit: ryanb/letter_opener@e5fbf0f#diff-2e20cc2a223324b62e266a1e07ce55e7
LetterOpener::Message.rendered_messageschanged from......to...
locationis now an option, and not an argument to the method.