-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Launchy and ignore executable command detection #75
Disable Launchy and ignore executable command detection #75
Conversation
ef8dfc6
to
2a00b4b
Compare
@pseudomuto ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey man, thanks for the PR! I have a small nitpick about a typo, but otherwise this LGTM 👍
@iguchi1124 thanks for pinging me
super | ||
ENV['LAUNCHY_DRY_RUN'] = 'false' | ||
rescue Launchy::CommandNotFoundError # rubocop:disable HandleExceptions | ||
# Ignore for non-executable Launchy envirofment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/envirofment/environment/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops :<
I fixed and rebased as 661ef92 .
When Launchy runs dry run mode, its runner will detect executable command. Ref: https://github.com/copiousfreetime/launchy/blob/v2.4.3/lib/launchy/detect/runner.rb#L58 It makes sense for Launchy. So letter_opener_web should avoid this error.
2a00b4b
to
661ef92
Compare
Thanks for your merge, @pseudomuto ! Could you release a new version? |
Just released v1.3.3 |
Great thanks ✨ |
When Launchy runs dry run mode, its runner will detect executable command.
Ref: https://github.com/copiousfreetime/launchy/blob/v2.4.3/lib/launchy/detect/runner.rb#L58
It makes sense for Launchy. So letter_opener_web should be avoid this error.
This PR follows up #73.