Add require_dependency #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@koheisg this looks good, but can you change those double quotes to single quotes? I know it seems silly, but I once made a giant commit to fix all the rubocop errors and never want to do it again 😄 You can run |
koheisg
force-pushed
the
add-require_dependency
branch
from
bd271dd
to
ff74b53
Compare
|
@pseudomuto thank you for your support. I checked CI is green. |
|
@pseudomuto we're hitting this as well. Glad to see it is fixed! Would you be able to cut a release of the gem that includes this? |
|
@jnraine version 1.3.4 has been released |
|
@fgrehm Can you make a release so that we can use this fix? Thanks |
|
@rafaelsales v1.3.4 has been released with this patch. Are you having issues with the require dependency? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davekaro @pseudomuto
thank you for your feedbacks on #79