Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

Getting vagrant-lxc work with system bridge for private network #354

Closed
wants to merge 2 commits into from
Closed

Getting vagrant-lxc work with system bridge for private network #354

wants to merge 2 commits into from

Conversation

podarok
Copy link
Contributor

@podarok podarok commented Mar 16, 2015

Fixing #353 issue

With this patch system bridge can be used like a charm out of the box

Fixing #353 issue
@fgrehm
Copy link
Owner

fgrehm commented Mar 17, 2015

Thanks!

This is a good start but I'd prefer a patch that skips bridge removal in case it was not created by vagrant-lxc.... Lemme think about this a bit more

@podarok
Copy link
Contributor Author

podarok commented Mar 23, 2015

@fgrehm I have updated a place where remove_bridge invokes. So now routine should work without even calling remove_bridge when there is a system reserved bridge name
Needs test

@stucki
Copy link
Contributor

stucki commented Jul 6, 2015

There's a small bug in your https://github.com/podarok/vagrant-lxc/commit/65c7f956e7ae352317e1a5b7cb50810b909c2752: The variable name is "bridge" not "bridge_name".

@stucki
Copy link
Contributor

stucki commented Jul 6, 2015

See also #380

@fgrehm
Copy link
Owner

fgrehm commented Jul 16, 2015

Sorry for the long silence but as per GH-375 I'm looking for help to maintain this plugin and for now I'm holding back from bringing in new changes =/

If you are interested on maintaining the project and keep things moving please shoot me an email or drop a message on GH-375 so I can arrange things.

Cheers 🍻

@stucki stucki mentioned this pull request Aug 25, 2015
@stucki
Copy link
Contributor

stucki commented Aug 25, 2015

I've created a new PR which includes both changes from this one, but also includes the variable name fix, see #383.

@fpletz
Copy link
Contributor

fpletz commented Aug 25, 2015

Closing this in favor of #383.

Thanks @podarok! Your commits are included in the new PR.

@fpletz fpletz closed this Aug 25, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants