This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
Load locale file only once #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! I have some other caching improvements I've been working on too, I'll try to put up a PR this week. |
ccope
reviewed
Oct 18, 2016
| @@ -8,12 +8,16 @@ class Plugin < Vagrant.plugin("2") | |||
| The LXC provider allows Vagrant to manage and control | |||
| LXC-based virtual machines. | |||
| EOF | |||
| locale_loaded = false | |||
|
|
|||
| provider(:lxc, parallel: true, priority: 7) do | |||
There was a problem hiding this comment.
This appears to be in a parallel section, do we need to do some sort of locking here?
There was a problem hiding this comment.
I looked into docker and hyperv providers from vagrant-1.8.5 and found no locking there.
There was a problem hiding this comment.
Should I rewrite patch to use the same style (def self.init!) as in docker/plugin.rb ?
There was a problem hiding this comment.
Yeah, that sounds good to me. The docker provider is the newest in the main vagrant project and generally a good example to follow.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
My case is a bit unusual - we have near 200 machines defined by single Vagrantfile.
I found that command 'vagrant status' takes near 82seconds to run on empty setup. With strace I see that there are a lot of open("...vagrant-lxc-1.2.1/locales/en.yml") requests.
With attached patch time of 'vagrant status' reduced to 32seconds.
Configuration:
Ubuntu 16.04.1
Vagrant Version: 1.8.5
vagrant plugin list:
vagrant-lxc (1.2.1)
vagrant-share (1.1.5, system)