-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OA-Streams: Introduction of Cluster's Size #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @steveyuwono, I just took a look at your extensions. It looks good and should perfectly solve the problem. I just have a hint about using the MLPro properties. These have four different attributes:
These, in turn, are Python properties, which means they can be accessed as public attributes but implicitly call get/set methods.
To access the value of new MLPro property 'size' as intended you can say
instead of
There is actually just one reason for using the public method set: if you want to provide an explicit timestamp.
Hi Detlef, thank you for your review. Ahh sorry, we have discussed this but I forgot. It has now been updated accordingly. |
@steveyuwono could you please also extend the oa howtos by printing the sizes of the clusters at the end? |
I have done it in howto_oa_wr 001 to 005. Do all howto_oa_ca_* also need this extension? |
Hi Steve, yes please. Thank you! |
Okay, the updates have been made. |
Description
Background
Checklists: