Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refact: Renaming of class bf.systems.Controller #1052

Closed
6 of 7 tasks
detlefarend opened this issue Aug 31, 2024 · 2 comments · May be fixed by #1043
Closed
6 of 7 tasks

Refact: Renaming of class bf.systems.Controller #1052

detlefarend opened this issue Aug 31, 2024 · 2 comments · May be fixed by #1043
Assignees
Labels
BF Basic Functions/Infrastructure next release quality Quality assurance refactoring Restructuring, renaming, simplification, understandability, ...

Comments

@detlefarend
Copy link
Member

detlefarend commented Aug 31, 2024

Motivation
This class enables access to external sensors and actuators. Since we are to extend MLPro by closed-loop control with controller classes we need to find a better name for this class to avoid name collisions and misunderstandings.

Proposals are:

  • SAHub ('Sensor/Actuator-Hub')
  • SAGateway ('Sensor/Actuator-Gateway')

Benefit
Avoidance of name collisions and misunderstandings.

Are the proposed changes backward compatible?

  • Yes
  • No

Related development objects

  • Class bf.systems.Controller
  • Class bf.systems.System
    • Method add_controller
  • Related howtos
  • RTD: Update of related class diagram
@detlefarend detlefarend added quality Quality assurance refactoring Restructuring, renaming, simplification, understandability, ... labels Aug 31, 2024
@detlefarend
Copy link
Member Author

Hi @steveyuwono, what do you think? Do you have a better name in mind?

@detlefarend detlefarend added the BF Basic Functions/Infrastructure label Aug 31, 2024
@steveyuwono
Copy link
Collaborator

Hi @steveyuwono, what do you think? Do you have a better name in mind?

Hi @detlefarend , SAHub and SAGateway sound nice and catchy. At the moment, I can not find anything better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BF Basic Functions/Infrastructure next release quality Quality assurance refactoring Restructuring, renaming, simplification, understandability, ...
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants