Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model Improvements #116

Merged
merged 4 commits into from
Oct 18, 2021
Merged

Model Improvements #116

merged 4 commits into from
Oct 18, 2021

Conversation

detlefarend
Copy link
Member

No description provided.

@detlefarend detlefarend added the enhancement New feature or request label Oct 17, 2021
@detlefarend detlefarend self-assigned this Oct 17, 2021
@detlefarend detlefarend linked an issue Oct 17, 2021 that may be closed by this pull request
RL-Env: Online adaptive environments #99
Closed
@detlefarend detlefarend removed a link to an issue Oct 17, 2021
RL-Env: Online adaptive environments #99
Closed
This was linked to issues Oct 17, 2021
Agent Adaptation Algorithm(3) #117
Closed
Agent Adaptation #110
Closed
@detlefarend detlefarend removed a link to an issue Oct 17, 2021
Agent Adaptation Algorithm(3) #117
Closed
This was linked to issues Oct 17, 2021
New property class "ScientificObject" #42
Closed
Agent/Policy: Observation space instead of state space #118
Closed
This was unlinked from issues Oct 18, 2021
New property class "ScientificObject" #42
Closed
Agent Adaptation #110
Closed
@detlefarend detlefarend marked this pull request as ready for review October 18, 2021 07:49
@rizkydiprasetya
Copy link
Contributor

Use copy function on the self._previous_obs = self._observation, otherwise, somehow in the middle of the loop, the value will change by itself. This was the problem last time when there was a mismatch between current state and next state.

@detlefarend detlefarend merged commit 17c2a44 into main Oct 18, 2021
@detlefarend detlefarend deleted the model_improvements branch October 18, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@detlefarend detlefarend

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Agent/Policy: Observation space instead of state space
2 participants
@detlefarend @rizkydiprasetya