Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/wrapper native sb3 policy for On-Policy #143

Merged
merged 15 commits into from
Oct 27, 2021

Conversation

rizkydiprasetya
Copy link
Contributor

Fixing the mismatch Native and Wrapper SB3 Policy.
Create How to, to do the comparison.

@rizkydiprasetya rizkydiprasetya changed the title Feature/wrapper native sb3 policy Feature/wrapper native sb3 policy for On-Policy Oct 27, 2021
@rizkydiprasetya
Copy link
Contributor Author

This is only for On-Policy. For Off-Policy will be on different PR. An issue is already created #144 and still work in progress. Unit test is also created, where it checks the policy loss. If no different in Policy Loss then it is ok.

Copy link
Member

@detlefarend detlefarend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool stuff! Thank you for your commitment!

@detlefarend detlefarend merged commit d6bc5c4 into main Oct 27, 2021
@detlefarend detlefarend deleted the feature/wrapper-native-sb3-policy branch October 27, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants