Further improvement on Buffer and BufferElement Class #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Did you check wether the howto's are still running? You added a second parameter done to method Agent.adapt(). This must be provided by the training class... |
detlefarend
reviewed
Sep 21, 2021
Yes, I checked. It doesnt matter, all the howtos dont have proper Policy. Even if we put a lot of buffer, they dont use it at all, since there is nothing on the Policy.adapt(). At the end the user need to redefine the Policy. And regarding the training class, it has been fixed on this #26 . |
|
For me its ok. Ultimately, you can best judge what we need there ... |
|
Let's solve this together... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Addresses:
Buffer Class Extension
Created from VS Code using CodeStream