Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OA: Online adaptivity12 #621

Merged
merged 44 commits into from
Mar 30, 2023
Merged

OA: Online adaptivity12 #621

merged 44 commits into from
Mar 30, 2023

Conversation

detlefarend
Copy link
Member

Description

Background

Checklists:

  • Read the CONTRIBUTION guide (required).
  • Update the history on the source code (required).

@detlefarend detlefarend added enhancement New feature or request v1.4.0 v1.4.0 Separation of Wrapper Code OA Online adaptivitiy labels Feb 12, 2023
@detlefarend
Copy link
Member Author

Hi @laxmikantbaheti @steveyuwono, I added a switch to turn off the view auto-selection. Howto howto_bf_streams_114_stream_task_deriver.py shows the following:

2023-02-12_16-55

@steveyuwono I am not sure whether this is plausible...

@detlefarend
Copy link
Member Author

@steveyuwono @laxmikantbaheti I also added a new howto_oa_pp_008_rearranger_deriver_normalizer.py. It extends howto_bf_streams_114_stream_task_deriver.py by a boundary detector and min/max normalizer:

2023-02-12_16-42

This howto processes all 721 instances of the stream. We can see that the input signal is symmetric. Two things are odd:

  • The boundary detector shows asymmetric boundaries for the derived features (@steveyuwono maybe, a problem of the deriver?)
  • The normalizer doesn't normalize the features to [-1,1]. I expected all three features in the range [-1,1]. (@laxmikantbaheti maybe, a problem of the normalizer? Or am I wrong?)

@laxmikantbaheti
Copy link
Contributor

@steveyuwono @laxmikantbaheti I also added a new howto_oa_pp_008_rearranger_deriver_normalizer.py. It extends howto_bf_streams_114_stream_task_deriver.py by a boundary detector and min/max normalizer:

2023-02-12_16-42

This howto processes all 721 instances of the stream. We can see that the input signal is symmetric. Two things are odd:

  • The boundary detector shows asymmetric boundaries for the derived features (@steveyuwono maybe, a problem of the deriver?)
  • The normalizer doesn't normalize the features to [-1,1]. I expected all three features in the range [-1,1]. (@laxmikantbaheti maybe, a problem of the normalizer? Or am I wrong?)

Hi, I think maybe it's a bug in BD, I'll check and update you!

@steveyuwono
Copy link
Collaborator

steveyuwono commented Feb 13, 2023

@steveyuwono @laxmikantbaheti I also added a new howto_oa_pp_008_rearranger_deriver_normalizer.py. It extends howto_bf_streams_114_stream_task_deriver.py by a boundary detector and min/max normalizer:

2023-02-12_16-42

This howto processes all 721 instances of the stream. We can see that the input signal is symmetric. Two things are odd:

  • The boundary detector shows asymmetric boundaries for the derived features (@steveyuwono maybe, a problem of the deriver?)
  • The normalizer doesn't normalize the features to [-1,1]. I expected all three features in the range [-1,1]. (@laxmikantbaheti maybe, a problem of the normalizer? Or am I wrong?)

Hi, thank you for letting us know. I will check this problem later.

@steveyuwono
Copy link
Collaborator

Hi @laxmikantbaheti @detlefarend , I just shortly checked the howto and found the possible cause of the problem. I think that the boundary detector detects the wrong boundary at the beginning, when the boundaries of all features are still empty.

The first data of the 0. feature is 10, therefore the boundary was detected as [10, 10]. But the first data of the 1. and 2. features are 0, then the boundary was detected as [0, 1]. I added a small if command to adjust with this situation.

I think, it looks correct now. The boundary of the 2. feature is barely seen because it is in between of [-0.012074550185936062, 0.012074550185937838].
image

@laxmikantbaheti
Copy link
Contributor

Hi @steveyuwono , thanks for the insight,
Also, there's a bug in renormalization of the plot data, I will try to solve this.

@steveyuwono
Copy link
Collaborator

Hi @steveyuwono , thanks for the insight, Also, there's a bug in renormalization of the plot data, I will try to solve this.

No worries. Sorry, which bug do you mean?

@laxmikantbaheti
Copy link
Contributor

laxmikantbaheti commented Feb 13, 2023

Hi @detlefarend @steveyuwono , I've found the bug,
I need to do a small change in normalizers module in bf math.
I will make that in QA 1.0.0 and merge it to OA12.
That's ok right?

@steveyuwono
Copy link
Collaborator

Hi @detlefarend @steveyuwono , I've found the bug, I need to do a small change in normalizers module in bf math. I will make that in QA 1.0.0 and merge it to OA12. That's ok right?

Yes, that's fine

@laxmikantbaheti
Copy link
Contributor

laxmikantbaheti commented Feb 13, 2023

Hi @detlefarend , @steveyuwono , I've fixed the bug. Now the normalization plots are updated correctly at each boundary detection event.

@detlefarend
Copy link
Member Author

I just checked it. Now it looks plausible. Good job!

@detlefarend detlefarend linked an issue Mar 22, 2023 that may be closed by this pull request
5 tasks
@detlefarend detlefarend added v1.2.0 Extension Hub and removed v1.4.0 v1.4.0 Separation of Wrapper Code labels Mar 30, 2023
@detlefarend detlefarend marked this pull request as ready for review March 30, 2023 10:25
@detlefarend detlefarend merged commit 4f2da48 into main Mar 30, 2023
@detlefarend detlefarend deleted the online_adaptivity12 branch March 30, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment