Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Persistence #669

Merged
merged 34 commits into from
Mar 30, 2023
Merged

BF: Persistence #669

merged 34 commits into from
Mar 30, 2023

Conversation

detlefarend
Copy link
Member

Description

Background

Checklists:

  • Read the CONTRIBUTION guide (required).
  • Update the history on the source code (required).

@detlefarend detlefarend added refactoring Restructuring, renaming, simplification, understandability, ... BF Basic Functions/Infrastructure next release labels Mar 14, 2023
@detlefarend detlefarend added this to the Sprint 2023/03 milestone Mar 14, 2023
@detlefarend detlefarend self-assigned this Mar 14, 2023
@detlefarend detlefarend linked an issue Mar 14, 2023 that may be closed by this pull request
30 tasks
@detlefarend
Copy link
Member Author

@rizkydiprasetya I have currently no idea, why in particular howto_rl_att_002 failed in the last workflow run. It runs locally (direct and unit test). Do you have an idea?

@rizkydiprasetya
Copy link
Contributor

@detlefarend fyi, I changed the way it runs the example modules in unit test.

@detlefarend detlefarend added v1.1.0 In scope of Release 1.1.0 and removed next release labels Mar 29, 2023
@detlefarend detlefarend marked this pull request as ready for review March 29, 2023 19:08
@detlefarend
Copy link
Member Author

@steveyuwono @rizkydiprasetya @laxmikantbaheti, the technical properties of the new class Persistent have been validated by Steve and myself. It would be nice if you could read/review the related rtd section and give me feedback. Thanks in advance!

@laxmikantbaheti
Copy link
Contributor

laxmikantbaheti commented Mar 29, 2023

@steveyuwono @rizkydiprasetya @laxmikantbaheti, the technical properties of the new class Persistent have been

Hi everyone, I am currently having problems with RTD Build, specifically importing the jquery extension, although I have installed all the requirements.
What can be possible reasons?

@detlefarend
Copy link
Member Author

@steveyuwono @rizkydiprasetya @laxmikantbaheti, the technical properties of the new class Persistent have been

Hi everyone, I am currently having problems with RTD Build, specifically importing the jquery extension, although I have installed all the requirements. What can be possible reasons?

Hey ho, did you try to remove local folder mlpro/doc/rtd/_build?

@laxmikantbaheti
Copy link
Contributor

Hey ho, did you try to remove local folder mlpro/doc/rtd/_build?

That worked. Thanks 👍

@laxmikantbaheti
Copy link
Contributor

laxmikantbaheti commented Mar 29, 2023

@steveyuwono @rizkydiprasetya @laxmikantbaheti, the technical properties of the new class Persistent have been validated by Steve and myself. It would be nice if you could read/review the related rtd section and give me feedback. Thanks in advance!

Hi @detlefarend , the documentation looks good. It's straightforward to understand all the methods. But, in sections "Saving Objects" and "Loading Objects" , the content becomes discontinuous because of the block (stating default file names in for saving, and attribute "C_PERSISTENCE_VERSION"). In other words, half of the sentence is above the block and the rest starts below.

@detlefarend
Copy link
Member Author

@steveyuwono @rizkydiprasetya @laxmikantbaheti, the technical properties of the new class Persistent have been validated by Steve and myself. It would be nice if you could read/review the related rtd section and give me feedback. Thanks in advance!

Hi @detlefarend , the documentation looks good. It's straightforward to understand all the methods. But, in sections "Saving Objects" and "Loading Objects" , the content becomes discontinuous because of the block (stating default file names in for saving, and attribute "C_PERSISTENCE_VERSION"). In other words, half of the sentence is above the block and the rest starts below.

Hi @laxmikantbaheti, thank you for your feedback. I reworked the section and the image and reduced the discontinuity.

@steveyuwono
Copy link
Collaborator

@steveyuwono @rizkydiprasetya @laxmikantbaheti, the technical properties of the new class Persistent have been validated by Steve and myself. It would be nice if you could read/review the related rtd section and give me feedback. Thanks in advance!

Hi Detlef, after several updates, the documentation looks clear and understandable.

@detlefarend detlefarend merged commit d5b9484 into main Mar 30, 2023
@detlefarend detlefarend deleted the persistence branch March 30, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BF Basic Functions/Infrastructure refactoring Restructuring, renaming, simplification, understandability, ... v1.1.0 In scope of Release 1.1.0
Projects
None yet
4 participants