Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WR: Add Gymnasium Wrapper #714

Merged
merged 6 commits into from
Apr 11, 2023
Merged

Conversation

rizkydiprasetya
Copy link
Contributor

@rizkydiprasetya rizkydiprasetya commented Apr 9, 2023

Description

close #429

Background

Checklists:

  • Read the CONTRIBUTION guide (required).
  • Update the history on the source code (required).

@rizkydiprasetya rizkydiprasetya self-assigned this Apr 9, 2023
@rizkydiprasetya rizkydiprasetya added enhancement New feature or request WR 3rd-party support ("Wrapper") labels Apr 9, 2023
@rizkydiprasetya rizkydiprasetya added this to the Sprint 2023/04 milestone Apr 9, 2023
@rizkydiprasetya rizkydiprasetya linked an issue Apr 9, 2023 that may be closed by this pull request
5 tasks
@rizkydiprasetya
Copy link
Contributor Author

@detlefarend @steveyuwono

@steveyuwono
Copy link
Collaborator

steveyuwono commented Apr 10, 2023

Hi @rizkydiprasetya , everything looks good and the howto works fine as well. Maybe just need to update the RTD in the following sections:

  • Sec 6.7. 3rd Party Support
  • A1 - Example Pool --> MLPro-RL --> Wrappers
  • A2 - API Reference --> Wrappers

Copy link
Member

@detlefarend detlefarend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As Steve already mentioned, it's just the rtd update to be done.

One question: it seems that gymnasium is compatible to openai gym and provides access to the same environments. Can we remove openai gym and follow gymnasium?

@rizkydiprasetya
Copy link
Contributor Author

Looks good! As Steve already mentioned, it's just the rtd update to be done.

One question: it seems that gymnasium is compatible to openai gym and provides access to the same environments. Can we remove openai gym and follow gymnasium?

We could, but I would rather to separate them. As Open AI Gym is no longer updated and we use it only because of the dependencies of SB3. So, I would keep it there until SB3 updates their Gym to Gymnasium. And as Gymnasium is still continuously updating, it is easier to maintain the wrapper if we have separate file.

@detlefarend
Copy link
Member

Looks good! As Steve already mentioned, it's just the rtd update to be done.

One question: it seems that gymnasium is compatible to openai gym and provides access to the same environments. Can we remove openai gym and follow gymnasium?

We could, but I would rather to separate them. As Open AI Gym is no longer updated and we use it only because of the dependencies of SB3. So, I would keep it there until SB3 updates their Gym to Gymnasium. And as Gymnasium is still continuously updating, it is easier to maintain the wrapper if we have separate file.

That makes sense.

@rizkydiprasetya rizkydiprasetya merged commit c2ebab5 into main Apr 11, 2023
@rizkydiprasetya rizkydiprasetya deleted the wr/gymnasium/new_implementation branch April 11, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v1.2.0 Extension Hub WR 3rd-party support ("Wrapper")
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrapper: Replace wrapper for Gym by Gymnasium Update Gym Wrapper: following v0.26.1 or latest
3 participants