-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WR: Add Gymnasium Wrapper #714
Conversation
Hi @rizkydiprasetya , everything looks good and the howto works fine as well. Maybe just need to update the RTD in the following sections:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! As Steve already mentioned, it's just the rtd update to be done.
One question: it seems that gymnasium is compatible to openai gym and provides access to the same environments. Can we remove openai gym and follow gymnasium?
We could, but I would rather to separate them. As Open AI Gym is no longer updated and we use it only because of the dependencies of SB3. So, I would keep it there until SB3 updates their Gym to Gymnasium. And as Gymnasium is still continuously updating, it is easier to maintain the wrapper if we have separate file. |
That makes sense. |
Description
close #429
Background
Checklists: