Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WR: Gym removal, SB3 update to 2.0 alpha #741

Merged
merged 10 commits into from
Apr 23, 2023

Conversation

rizkydiprasetya
Copy link
Contributor

@rizkydiprasetya rizkydiprasetya commented Apr 19, 2023

Description

Removing Open AI Gym, Upgrade SB3 to Version 2.0 alpha.

Background

Checklists:

  • Remove Open AI Gym Wrapper
  • Refactor import module
  • Check all CI
  • Check all howtos
  • Update RTD
  • Read the CONTRIBUTION guide (required).
  • Update the history on the source code (required).

@rizkydiprasetya rizkydiprasetya self-assigned this Apr 19, 2023
@rizkydiprasetya rizkydiprasetya added the WR 3rd-party support ("Wrapper") label Apr 19, 2023
@detlefarend detlefarend linked an issue Apr 19, 2023 that may be closed by this pull request
4 tasks
@detlefarend
Copy link
Member

Hi @rizkydiprasetya, fyi: I just added the related issue for it.

@detlefarend detlefarend added the v1.2.0 Extension Hub label Apr 19, 2023
@detlefarend detlefarend added this to the Sprint 2023/04 milestone Apr 19, 2023
@detlefarend detlefarend added quality Quality assurance RL Reinforcement Learning labels Apr 19, 2023
@rizkydiprasetya
Copy link
Contributor Author

@detlefarend update : I am currently checking the differ losses between Native and Wrapper. The rest are working fine.

Screenshot 2023-04-20 at 10 29 25

@rizkydiprasetya rizkydiprasetya merged commit 4763055 into main Apr 23, 2023
@rizkydiprasetya rizkydiprasetya deleted the wr/gym_removal_sb3_alpha branch August 22, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality Quality assurance RL Reinforcement Learning v1.2.0 Extension Hub WR 3rd-party support ("Wrapper")
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WR: End of OpenAI Gym support in MLPro
2 participants