Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Visualization of a cluster needs to be removed when cluster itse… #932

Merged
merged 5 commits into from
Feb 25, 2024

Conversation

detlefarend
Copy link
Member

…lf is destroyed #931

@detlefarend detlefarend added the OA Online adaptivitiy label Feb 23, 2024
@detlefarend detlefarend self-assigned this Feb 23, 2024
@detlefarend detlefarend marked this pull request as ready for review February 23, 2024 16:20
@detlefarend
Copy link
Member Author

Hi @steveyuwono, the problem of remaining plot artifacts after the removal of a cluster should be solved now. Could you please confirm and merge to main afterwards? Thx!

@steveyuwono
Copy link
Collaborator

Hi @steveyuwono, the problem of remaining plot artifacts after the removal of a cluster should be solved now. Could you please confirm and merge to main afterwards? Thx!

Hi @detlefarend , thank you for the updates. The removal of clusters in the plot is now fixed. However, the red arrows (see attachment) from removed clusters still remain in the plot
image

@detlefarend
Copy link
Member Author

Hi @steveyuwono, the problem of remaining plot artifacts after the removal of a cluster should be solved now. Could you please confirm and merge to main afterwards? Thx!

Hi @detlefarend , thank you for the updates. The removal of clusters in the plot is now fixed. However, the red arrows (see attachment) from removed clusters still remain in the plot image

Ah, of course. I'll take a look...

@detlefarend
Copy link
Member Author

@steveyuwono here we go. Please check once again. Btw: Which howto did to use? I also suggest to map the cluster IDs internally to integer numbers by using an internal counter.

@steveyuwono
Copy link
Collaborator

@steveyuwono here we go. Please check once again. Btw: Which howto did to use? I also suggest to map the cluster IDs internally to integer numbers by using an internal counter.

perfect, it is solved now! I am using howto_oa_ca_031 in MLPro-Int-River. Okay, I will update the cluster IDs accordingly in "oa/howtos" branch of MLPro-Int-River

@detlefarend detlefarend merged commit 7fd3622 into main Feb 25, 2024
9 checks passed
@detlefarend detlefarend deleted the bf/oa/streams/ca/plot branch February 25, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OA Online adaptivitiy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Visualization of a cluster needs to be removed when cluster itself is destroyed
2 participants