Sidecars #146
Merged
Sidecars #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vious fluentd sidecar took 5m to 'terminate'), but also becaus the fluentd-gcp image is not maintained anymore.
LimKianAn
reviewed
Mar 5, 2021
LimKianAn
reviewed
Mar 5, 2021
LimKianAn
reviewed
Mar 5, 2021
LimKianAn
reviewed
Mar 5, 2021
LimKianAn
reviewed
Mar 5, 2021
LimKianAn
reviewed
Mar 5, 2021
LimKianAn
reviewed
Mar 5, 2021
| @@ -108,7 +108,7 @@ func (r *StatusReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr | |||
| return ctrl.Result{}, fmt.Errorf("failed to update lbSocket of Postgres: %w", err) | |||
| } | |||
| } else { | |||
| log.Error(err, "failed to fetch the corresponding Service of type LoadBalancer") | |||
| log.Info("unable to fetch the corresponding Service of type LoadBalancer") | |||
There was a problem hiding this comment.
Should we also distinguish NotFound error from other errors?
LimKianAn
reviewed
Mar 5, 2021
LimKianAn
reviewed
Mar 5, 2021
LimKianAn
reviewed
Mar 5, 2021
| m.log.Info("Sidecars ConfigMap updated") | ||
| return objs, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
Errors other than NotFound not handled here.
LimKianAn
reviewed
Mar 5, 2021
LimKianAn
reviewed
Mar 5, 2021
Sidecars Services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.