11 separate reconciler to consume zalando status and update into our postgres type #18
Conversation
…consume_zalando_status_and_update_into_our_postgres_type
…nto 11_separate_reconciler_to_consume_zalando_status_and_update_into_our_postgres_type
…date_into_our_postgres_type' of https://github.com/fi-ts/postgres-controller into 11_separate_reconciler_to_consume_zalando_status_and_update_into_our_postgres_type
Add UID in zalando postgresql name
| log.Info("fetching postgresql") | ||
| instance := &zalando.Postgresql{} | ||
| if err := r.Client.Get(ctx, req.NamespacedName, instance); err != nil { | ||
| if !errors.IsNotFound(err) { |
There was a problem hiding this comment.
There was a problem hiding this comment.
I just doube checked, and I will keep it the way it is so we can log a message that the object was deleted. If we just return, we can't do that.
There was a problem hiding this comment.
I thought the returned err would contain the info of the object we wanted to fetch. If that's not the case, agreed.
| break | ||
| } | ||
|
|
||
| if !ownerFound { |
There was a problem hiding this comment.
Consider var owner *pg.Postgres. Then we can evaluate if owner == nil and don't need an extra variable.
There was a problem hiding this comment.
Consider
owner := &ps.Postgres{}
*owner = o
There was a problem hiding this comment.
Now that we have a separate owner and o variable, we could indeed remove that bool. It doesn't hurt however, so I will keep it for now.
eberlep
deleted the
11_separate_reconciler_to_consume_zalando_status_and_update_into_our_postgres_type
branch
Implements #11